t/porting/libperl.t: add better diagnostics #22447
Conversation
|
I've pushed an updated version. I've make it look for cross-ref symbol candidates by just grabbing any words on each line, rather than by just using parsed symbols on every known-format branch. So its more likely to find lines where the symbol appears, even if the line hasn't been well-parsed (which is kind of the idea behind these new diagnostics anyway). |
t/porting/libperl.t
Outdated
|
|
||
| # generate a cross-ref of every line each symbol appears on, | ||
| # for diagnostics | ||
| for my $sym (grep !/^[0-9A-Fa-f]+$/, /\b(\w{2,})\b/g) { |
There was a problem hiding this comment.
[0-9A-Fa-f] could be written as [[:xdigit:]], which I like better.
$ is semantically wrong; should be \z.
But I'd probably invert the whole thing and write grep /[^[:xdigit:]]/, ... ("must contain a non-hex-digit").
(The second regex could be just /\w{2,}/g, but the explicit form is fine, too.)
t/porting/libperl.t
Outdated
| for my $sym (grep !/^[0-9A-Fa-f]+$/, /\b(\w{2,})\b/g) { | ||
| push @{$symbols->{xref}{$sym}}, | ||
| sprintf "%20s: %s", $symbols->{o}, $line; | ||
| } |
There was a problem hiding this comment.
Duplicate code. Maybe factor out into subroutine?
If it fails to find a symbol where expected (e.g. in the text section of the object file), then print a diagnostic message which lists all the nm lines where the symbol *was* found (if any). This is achieved by adding a xref hash which maps symbol names to arrays of lines / object files. Also document the format of the %symbols hash.
|
Updated based on feedback and rebased. Third time lucky? |
In the commit message you say: "If it fails to find a symbol where expected (e.g. in the text section of the object file), then print a diagnostic message which lists all the nm lines where the symbol was found (if any)." Is there any way I could trick the program into printing out that diagnostic? |
|
On Thu, Aug 01, 2024 at 08:07:19AM -0700, James E Keenan wrote:
Is there any way I could trick the program into printing out that diagnostic?
Yes. For example, consider this chunk of code:
has_symbol('PL_hash_seed_w',
$symbols{data}{common}{PL_hash_seed_w}{'globals.o'},
"has PL_hash_seed_w");
To get the "but it was seen in these places" diagnostic, change the 'data'
to 'XXX' in the code above so that it fails to find the symbol in the
'XXX' section.
To get the "nor was it seen elsewhere" diagnostic, do
s/PL_hash_seed_w/XXX/g in the lines above.
…--
Fire extinguisher (n) a device for holding open fire doors.
|
Confirmed. Thanks. |
If it fails to find a symbol where expected (e.g. in the text section of the object file), then print a diagnostic message which lists all the nm lines where the symbol was found (if any).
This is achieved by adding a xref hash which maps symbol names to arrays of lines / object files.
Also document the format of the %symbols hash.